Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Work on CPU GPIO #1696

Merged
merged 7 commits into from
Sep 8, 2020
Merged

Work on CPU GPIO #1696

merged 7 commits into from
Sep 8, 2020

Conversation

josesimoes
Copy link
Member

Description

  • Rework code so that the INT hander is setup only if there are managed callbacks registered.
  • Rework GPIO interrupt handler and debounce handler on TI SimpleLink.

Motivation and Context

How Has This Been Tested?

  • Blinky and GPIO+Events samples.

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@josesimoes
Work on CPU GPIO
66c7a29 
- Rework code so that the INT hander is setup only if there are managed callbacks registered.
- Rework GPIO interrupt handler and debounce handler on TI SimpleLink.
@nfbot
Copy link
Member

nfbot commented Sep 8, 2020

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes added Area: Common libs Everything related with common libraries Area: Targets labels Sep 8, 2020
@nfbot
Copy link
Member

nfbot commented Sep 8, 2020

@josesimoes there are issues with the code style on the source files.
A PR was submitted with the code style fixes. Please review and merge the changes. See Eclo#30.

Make sure you are using the project code style. Check the details here.

@nfbot
Copy link
Member

nfbot commented Sep 8, 2020

@josesimoes there are issues with the code style on the source files.
A PR was submitted with the code style fixes. Please review and merge the changes. See Eclo#31.

Make sure you are using the project code style. Check the details here.

nfbot and others added 2 commits September 8, 2020 09:35
@nfbot
Code style fixes (#31)
fbecc61 
Automated fixes for code style.
@josesimoes
Remove unnecessary array
00e0701 
- Fix code style fix
@nfbot
Copy link
Member

nfbot commented Sep 8, 2020

@josesimoes there are issues with the code style on the source files.
A PR was submitted with the code style fixes. Please review and merge the changes. See Eclo#32.

Make sure you are using the project code style. Check the details here.

nfbot and others added 2 commits September 8, 2020 09:56
@nfbot
Code style fixes (#32)
300e98e 
Automated fixes for code style.
@josesimoes
Remove wrong call.
ec8a9dc
@josesimoes josesimoes merged commit 0ac8d02 into nanoframework:develop Sep 8, 2020
@josesimoes
Copy link
Member Author

@MateuszKlatecki when you have the time, please give it a try to GPIO. Basically would like to know if the improvements here didn't break anything. 😉

@josesimoes josesimoes deleted the work-gpio branch September 8, 2020 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Area: Common libs Everything related with common libraries Area: Targets Type: bug Type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TI EasyLink GPIO Interrupt does Not Fire
2 participants
@josesimoes @nfbot